cleanup 2.0: replace django-saml2-auth with django-saml2-pro-auth or djangosaml2 #3890
Comments
valentijnscholten
changed the title
valentijnscholten
changed the title
|
I suggest djangosaml2 😄 |
alles-klar
added a commit
to alles-klar/django-DefectDojo
that referenced
this issue
Apr 14, 2021
Issue: DefectDojo#3890 Only the first changes. On behalf of DB Systel GmbH
valentijnscholten
changed the title
|
Could I ask whether this will still be part of 2.0.0 and what the rough planned release date is for that? We are unable to get our old ADFS system working with the current SAML plugin and we're hoping djangosaml2 will work for us. |
|
@quaffapint we pinned this modification for |
Maffooch
added a commit
that referenced
this issue
Jun 26, 2021
* feat: replace django-saml2-auth with djangosaml2 Issue: #3890 Only the first changes. On behalf of DB Systel GmbH * feat: refactor saml2 settings * feat: refactor saml2 settings * feat: refactor saml2 settings * docs(saml): migration to djangosaml2 * fix: flake8 error * docs(upgrading): add saml2 part to upgrading documentation * Update settings.dist.py Co-authored-by: valentijnscholten <[email protected]> Co-authored-by: Cody Maffucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
django-saml2-auth is no longer maintained making it a security risk and incompatible with some newer libraries.
For example, it requires
PyJWT<2, where other libraries have switched toPyJWT>=2.0.0(issue)This prevents us from:
A) doing a clean install from requirements needing the legacy resolver which will be removed later this year (Q1?)
B) locking out dependencies with pipenv
C) upgrading to django 3+ or even 2.2+ (already at risk using django 2.2)
D) using python 3.6 or higher (we are already at risk using 3.6)
The replacement seems to be django-saml2-pro-auth
Or we could use djangosaml2 which is mentioned in our README.md
The text was updated successfully, but these errors were encountered: