Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace django-saml2-auth with djangosaml2 #4117

Merged
merged 13 commits into from
Jun 26, 2021
Merged

feat: replace django-saml2-auth with djangosaml2 #4117

merged 13 commits into from
Jun 26, 2021

Conversation

alles-klar
Copy link
Contributor

@alles-klar alles-klar commented Mar 24, 2021 •
edited
Loading

Issue: #3890

Documentation is part of the commit.

On behalf of DB Systel GmbH

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@valentijnscholten valentijnscholten force-pushed the dev branch 3 times, most recently from 15adbf2 to a0eacf3 Compare March 31, 2021 17:19
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@alles-klar
feat: replace django-saml2-auth with djangosaml2
d04a308 
Issue: DefectDojo#3890
Only the first changes.

On behalf of DB Systel GmbH
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@valentijnscholten valentijnscholten mentioned this pull request May 14, 2021
Merged
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@alles-klar alles-klar marked this pull request as ready for review May 27, 2021 13:15
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@devGregA
Copy link
Contributor

devGregA commented Jun 7, 2021

@alles-klar haven't forgotten about this, feedback coming shortly.

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Maffooch
Maffooch reviewed Jun 17, 2021
View reviewed changes
Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is a little more complicated than the old one, but way more configurable. Definitely a good move from a maintainability perspective.

I migrated my dev instance from the old to the new, and it wasn't too painful. Lots of reading the docs and debugging to get the gist of things, but that's kinda unavoidable with anything saml related.

Will approve on comment resolution.

dojo/settings/settings.dist.py Outdated Show resolved Hide resolved
dojo/settings/settings.dist.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@valentijnscholten valentijnscholten added this to the 2.0.0 milestone Jun 26, 2021
@valentijnscholten valentijnscholten added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR Breaking Changes labels Jun 26, 2021
@alles-klar alles-klar requested a review from Maffooch June 26, 2021 18:40
@Maffooch Maffooch merged commit 2ded267 into DefectDojo:dev Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maffooch Maffooch Maffooch approved these changes

@valentijnscholten valentijnscholten valentijnscholten approved these changes

Assignees
No one assigned
Labels
Breaking Changes settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alles-klar @devGregA @valentijnscholten @Maffooch