Async Delete: Race condition bolstering

[Maffooch]

Adding some potential guardrails for race conditions related to async delete

[sc-8961]

[dryrunsecurity]

DryRun Security Summary

The pull request aims to improve the reliability of DefectDojo's object deletion process by updating the delete() methods of Engagement, Test, and Finding models to use the suppress() function, ensuring the application continues to function correctly when related objects are deleted asynchronously.

Expand for full summary

Summary:

The changes in this pull request are focused on improving the handling of deletion and related object deletion within the DefectDojo application. The key changes involve updating the delete() methods of the Engagement, Test, and Finding models to use the suppress() function to handle potential issues caused by asynchronous deletion of related objects. This includes wrapping calls to the calculate_grade() function in suppress() blocks to ensure that the application can continue to function correctly even when related objects, such as Product or Engagement, no longer exist.

These changes are likely aimed at improving the reliability and robustness of the application when dealing with the deletion of findings, tests, and engagements, particularly in scenarios where related objects may have been deleted asynchronously or in a separate task. From an application security perspective, these changes do not appear to introduce any new security risks, but rather focus on improving the overall stability and reliability of the application, which can indirectly improve security by ensuring that the application continues to function correctly even in the face of potential issues with related objects.

Files Changed:

• dojo/models.py: This file contains the updates to the delete() methods of the Engagement, Test, and Finding models. The changes involve using the suppress() function to handle potential issues caused by asynchronous deletion of related objects, such as Product and Engagement. The updates are focused on improving the reliability and robustness of the application when dealing with the deletion of findings, tests, and engagements.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

[mtesauro]

Approved

[blakeaowens]

nice!