-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make alpine builds work with docker compose #11669
base: dev
Are you sure you want to change the base?
Conversation
DryRun Security SummaryThe code changes involve updates to two Dockerfiles, with minor image name changes in Dockerfile.django-alpine and Node.js/Yarn version updates in Dockerfile.nginx-alpine, both maintaining security best practices such as using non-root users, secure dependency installation, and proper key management. Expand for full summarySummary: The provided code changes involve updates to two Dockerfiles: From an application security perspective, both Dockerfiles follow security best practices, such as using a non-root user, installing dependencies securely, and including various entrypoint scripts for different components of the application. The update to the Node.js and Yarn versions in the Files Changed:
Code AnalysisWe ran |
We are on the same page 😀 |
Happy to close mine, but I added another fix that is needed when you're not buildng on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both PRs can go in
The docker compose expects
django
as target image, notdjango-alpine
.The release keys for Node where outdated, fixed as well.