-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New nexion project added #13086
New nexion project added #13086
Conversation
Error while running adapter at projects/nexion:
|
Error while running adapter at projects/nexion:
|
The adapter at projects/nexion exports TVL:
|
The adapter at projects/nexion exports TVL:
|
The adapter at projects/nexion exports TVL:
|
The adapter at projects/nexion exports TVL:
|
The adapter at projects/nexion exports TVL:
|
projects/nexion/index.js
Outdated
|
||
const plsin = await api.call({ | ||
target: contracts.NEONFarm, | ||
abi: farmAbi.valueofthis, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, what does this call return?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A portion of user deposits are sent to this farm contract. valueofthis() tracks the plsvalue received.
function valueofthis() external view returns (uint256 plsvalue) {
address[] memory path = new address;
path[0] = address(PLS);
path[1] = address(DAI);
uint256 price = ISwapRouter(PULSEX_V2).getAmountsOut(10 ** 18, path)[1];
plsvalue = (plsin * price) / 10 ** 18;
}
This is then used to buy DAI-PLS LP and the LP is burned. It stays there forever and rewards users. We rehypothecate on this farm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, no. If the LP is burnt, it is not tvl, we can count what users can withdraw as tvl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, anywhere else i could add this value? As staking perhaps? If not thats ok , we'll leave it out thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, yeah. you need to leave it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok what about native token and LP?
We also have a staking where users stake NEON and earn NEON and INC token.
we also have around 9k $ in LP (NEON/PLS, NEON/DAI etc..all NEON pairs) Can i add these as tvl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can count staked NEON under staking
We can count staked NEON/PLS, etc LPS under pool2
But we can count these only if the user can withdraw their deposits, else no.
projects/nexion/index.js
Outdated
async function tvl(api) { | ||
return sumTokens2({ | ||
api, | ||
owner: contracts.NEONBuynBurn, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, we can treat only the user deposits as tvl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A portion of user deposits go to buyNBurn contract. So these funds are from user deposits. Or am i missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain the mechanism, thought this comes from fees, that is usually the case when protocols use the term buyback and burn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users deposit PLS in auction and receive our token NEON. A portion of pls goes to this BB contract. Every 1 hour a function is triggered that uses PLS to buy NEON and burnt it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, unless user can withdraw the deposited PLS, we treat this as a swap in a dex and not locked value.
projects/nexion/index.js
Outdated
sdk.util.sumSingleBalance(balances, contracts.NEONFarm, plsin2); | ||
return balances; | ||
} | ||
const lps = ["0xE56043671df55dE5CDf8459710433C10324DE0aE"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is DAI-PLS LP and has nothing to do with your protocol, you can count it as tvl instead of pool2 if you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Error while running adapter at projects/nexion:
|
Error while running adapter at projects/nexion:
|
Error while running adapter at projects/nexion:
|
The adapter at projects/nexion exports TVL:
|
Error while running adapter at projects/nexion:
|
The adapter at projects/nexion exports TVL:
|
The adapter at projects/nexion exports TVL:
|
The adapter at projects/nexion exports TVL:
|
I added back DAI-PLS LP as tvl |
Havent approved this PR because, you are still counting the tvl in buyback and burn wallet " But we can count these only if the user can withdraw their deposits, else no." |
Hello, i added staking for neon. Users can withdraw this anytime without fees. im confused, let's just do these : Staking : Users can stake NEON in our NEONStaking and withdraw at any time. There is an error shown that is other project : |
Error while running adapter at projects/nexion:
|
The adapter at projects/nexion exports TVL:
|
The adapter at projects/nexion exports TVL:
|
The adapter at projects/nexion exports TVL:
|
1 similar comment
The adapter at projects/nexion exports TVL:
|
NOTE
Please enable "Allow edits by maintainers" while putting up the PR.
package-lock.json
file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CIName (to be shown on DefiLlama):
Nexion
Twitter Link:
https://x.com/nexionpulse
List of audit links if any:
Website Link:
https://nexionpulse.com/
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
NEXION — Built on PulseChain, powered by NEON
NEXION aims to become a widely used dApp ecosystem that offers users a variety of ways to participate and earn rewards!
Token address and ticker if any:
0xF2Da3942616880E52e841E5C504B5A9Fba23FFF0
NEON
Category (full list at https://defillama.com/categories) *Please choose only one:
Yield
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
We add total value of Buy and Burn contract and the total assets in Holovault farm.
Github org/user (Optional, if your code is open source, we can track activity):