-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: count rings as sonic TVL #13206
Conversation
Error while running adapter at projects/rings:
|
The adapter at projects/rings exports TVL:
|
Hi, thanks for the PR! Correct me if I’m wrong, but you tried to include the staking part of the protocol in the TVL, right? In that case, it’s better to include this in the staking section rather than the TVL. It’s also preferable to keep the code as it was previously. Currently, we count in the TVL the collateral on the Ethereum vaults, even if the CDP minting happens on Sonic via LayerZero. In general, we always prioritize counting the collateral in the TVL rather than using the token supply for TVL, as this ensures that the assets are properly backed |
If I didn't misunderstand your intentions, the adapter might look more like this instead :
|
@0xpeluche The idea wasn't really to count the staking but instead of having the whole TVL as counted on sonic instead of majority on ethereum as minting usually happens on sonic but we bridge afterwards the collaterals. If you wish to not count the totalSupply, could I refactor the adaptor to use the price of all the collaterals but only end up adding up as sonic chain ? |
I'm sorry, we can't do that. Even though I understand that most of the minting happens on Sonic, the collaterals are still on Ethereum. Therefore, the TVL is mostly on Ethereum because we don't count the minted CDP token but the tokens backing them |
The adapter at projects/rings exports TVL:
|
The adapter at projects/rings exports TVL:
|
Understood @0xpeluche , updated the PR to add staking + missing collaterals. The only problem I have is that the staking vaults aren't meant to only hold scUSD / scETH but also yield bearings assets such as silo lending, beets LP ... (currently it only holds beets LP and scUSD) |
Count rings total volume locked as rings