Preserve type hints for wrapped functions #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kadambishreyas <[email protected]>
Signed-off-by: kadambishreyas <[email protected]>
Signed-off-by: kadambishreyas <[email protected]>
mattalbr
requested changes
Jan 9, 2025
aebrahim
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of
typing.ParamSpecandtyping.TypeVarto parametrize input/output types for decorated functions, allowing us to preserve the types of decorated functions.We accomplish this on
once_per_classandonce_per_instanceby making the classes themselves generic.Since we require
typing.ParamSpecwhich was introduced inpython3.10, this PR also drops support forpython3.8andpython3.9in favour of remaining without dependencies.