Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running FloodAdapt on Linux #527

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Running FloodAdapt on Linux #527

wants to merge 16 commits into from

Conversation

Jaapel
Copy link
Contributor

@Jaapel Jaapel commented Aug 29, 2024

In order to run on linux, a few changes were made:

To do configuration I added pydantic-settings to our dependencies (maintained by pydantic maintainers, which is already in our dependencies.)

@Jaapel Jaapel added Bug Something isn't working Needs refinement Issues that still need to be discusses, made more concrete or prioritised labels Aug 29, 2024
@Jaapel Jaapel requested a review from LuukBlom August 29, 2024 09:15
@Jaapel Jaapel self-assigned this Aug 29, 2024
@Jaapel
Copy link
Contributor Author

Jaapel commented Aug 29, 2024

@LuukBlom can you take a look? We should chat on how we will deal with case-sensitive filepaths (with capitalization or without)

Copy link
Contributor

@LuukBlom LuukBlom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the new config module!

I only have 1 real comment (about actually validating the paths point to exe/binaries that exist.

Before merging this PR, we need to remove all calls to the old config module in FloodAdapt-GUI as well. (global search for from flood_adapt.config)

The old way using env vars is kind of clunky anyways and this does the same, but much better.

flood_adapt/config.py Show resolved Hide resolved
flood_adapt/object_model/benefit.py Show resolved Hide resolved
flood_adapt/config.py Outdated Show resolved Hide resolved
= added 3 commits September 16, 2024 19:35
…es for Linux & Darwin to the system folder in the test database
…s. fix Settings usage in integrator scripts
@savente93
Copy link
Contributor

This requires Pixi so moving it to blocked (#485)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta release Bug Something isn't working Needs refinement Issues that still need to be discusses, made more concrete or prioritised
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants