Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/gridedit 872 undo poc #291

Closed
wants to merge 9 commits into from
Closed

Feature/gridedit 872 undo poc #291

wants to merge 9 commits into from

Conversation

BillSenior
Copy link
Contributor

No description provided.

@ahmad-el-sayed
Copy link
Contributor

General comments:

  • Use #pragma once instead of guards in the headers
  • Class member functions should be capitalised
  • Class member variables should be prefixed by m_ rather than suffixed by _

@BillSenior BillSenior closed this Mar 11, 2024
@BillSenior BillSenior deleted the feature/GRIDEDIT-872_undo_in_meshkernel branch March 11, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacarniato lucacarniato Awaiting requested review from lucacarniato

@ahmad-el-sayed ahmad-el-sayed Awaiting requested review from ahmad-el-sayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillSenior @ahmad-el-sayed