Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First implementation of 'aanvoer' #255

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

First implementation of 'aanvoer' #255

wants to merge 59 commits into from

Conversation

ghendrickx
Copy link
Collaborator

@ghendrickx ghendrickx commented Feb 20, 2025 •
edited
Loading

Implementation of 'aanvoer'-conditions, including additional parametrisation-scripts to update Basins and Outlet to be flagged as aanvoer=True.

Main changes include:

  • Addition of supply.py.
  • Addition of set_aanvoer_flags() (from ribasim_parametrization.py).
  • Modification of determine_min_upstream_max_downstream_levels() (from ribasim_parametrization.py).

Hendrickx added 30 commits February 7, 2025 14:38
Updated .gitignore to ignore IDE-based folders.
75f9d66
Added processing for 'aanvoergebieden' and LHM-mods
eed3113
Added supply.py-content
c676964
Clean-up of AGV-parametrize file (rm *.ipynb formatting-leftovers)
9d0db46
QuickFix supply.py
f39a4fa
Clean-up of *.ipynb to *.py conversion: Scheldestromen.
f76a8ab
Clean-up of *.ipynb to *.py conversion: Delfland.
ef99535
Clean-up of *.ipynb to *.py conversion: Delfland.
47f136f
Clean-up of *.ipynb to *.py conversion: Hollands Noorderkwartier.
55b09ae
Clean-up of *.ipynb to *.py conversion: Rijnland.
ee21f91
Clean-up of *.ipynb to *.py conversion: Rivierenland.
8cac40d
Clean-up of *.ipynb to *.py conversion: Schieland en de Krimpenerwaard.
4dd6ff7
Clean-up of *.ipynb to *.py conversion: Fryslan.
18c84f8
Clean-up of *.ipynb to *.py conversion: Zuiderzeeland.
b2f8726
Clean-up documentation/file AGV.
5d61f78
Debugged implementation of 'wateraanvoer' (AGV).
7304f72
Implementation of *.gdb as supply-file (Delfland).
2f24a4a
Implementation of 'aanvoer' for Hollandse Delta.
ef57c05
Added 'extract'-method to 'special_load_geometry()'-function.
44cee0e
Implementation for Rijnland.
ab565e6
Added default export of modified 'aanvoer'-geometry.
b62606b
Simplified 'special_load_geometry()'-function.
0e4fb03
Implementation of for Rivierenland.
cb44a35
Implementation of for Scheldestromen.
10df66c
Implementation of for HHSK.
af8f3ac
Implementation for for Wetterskip.
5303d8c
Implementation for of Zuiderzeeland.
cc52621
Removing __main__-statement.
f9a0f75
Added aanvoer-flagging grouped in a single method in .
ce1c426
Debugging of 'aanvoer' using AGV-parametrisation.
c1bbb97
Hendrickx and others added 24 commits February 18, 2025 15:02
Hard-coded 'aanvoer'-function of Pump 990 (Linge).
98ae099
Updated Delfland for 'aanvoer'-conditions.
02bd9e2
Aanvoer implementation of HD (medium performance due to 'aanvoer'-pum…
613e7ca 
…ps not being labelled as 'aanvoer'?).
Increased default water level at boundaries for activation of outlets.
b5140ef
Implementation of Rijnland (aanvoer).
4453b68
Implementation of Scheldestromen (aanvoer).
a2a6616
Full 'waterschap' as 'aanvoergebied' without geodata (Zuiderzeeland).
cad1755
Implementation of HHNK (aanvoer).
f65625f
Re-added default water level values for 'afvoer' (having an 'if'-stat…
e33fc30 
…ement to decide which one to pick).
@rbruijnshkv
Add wateraanvoer indicators
f9868fb
@rbruijnshkv
Add new .qlr file for expanded output indicators
e2f10c0
@rbruijnshkv
Change path sturing.json
b570fa8
@rbruijnshkv
Delete outdated file
013adcd
@rbruijnshkv
Add wateraanvoer functionality
235f519
@rbruijnshkv
Revert wateraanvoer functionality
90a294a
@rbruijnshkv
Revert wateraanvoer functionality
fa9c97c
@rbruijnshkv
Always choose the most recent .qlr file, irrelevant of afvoer or aanv…
426f430 
…oer situation
@rbruijnshkv
Always choose the latest .qlr file
00984ed
@rbruijnshkv
Apply and import generic .qlr name (wateraanvoer)
1151a7d
Implementation of WF.
e41f4e6
@rbruijnshkv
Merge branch 'output_controle_aanvoer' into feature/aanvoergebieden
8da148b
@rbruijnshkv
Merge branch 'feature/aanvoergebieden' of https://github.com/Deltares…
780c359 
…/Ribasim-NL into feature/aanvoergebieden
Changed default boundary water level WF for aanvoer.
722dcc4
Updates to implementations.
3dc7022
@ghendrickx ghendrickx requested a review from visr February 20, 2025 16:37
@ghendrickx ghendrickx self-assigned this Feb 20, 2025
@ghendrickx ghendrickx linked an issue Feb 20, 2025 that may be closed by this pull request
uitwerken wateraanvoer situatie voor eerste waterschap #221
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr Awaiting requested review from visr

At least 1 approving review is required to merge this pull request.

Assignees

@ghendrickx ghendrickx

Labels
LHM-model Parameterisatie
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uitwerken wateraanvoer situatie voor eerste waterschap
2 participants
@ghendrickx @rbruijnshkv