Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial support for component settings with chart and report #1183

Open
wants to merge 60 commits into
base: main
Choose a base branch
from
Open

Add initial support for component settings with chart and report #1183

wants to merge 60 commits into from

Conversation

hvangeffen
Copy link
Collaborator

@hvangeffen hvangeffen commented Feb 3, 2025 •
edited
Loading

Description

Add support for component settings endpoint and implement initial settings for chart and report.
Now takes the basemaps from the config, and the overlays from the map settings.

Default settings can be found in: (unimplemented settings have been marked with a TODO)
https://github.com/Deltares/fews-web-oc/tree/add-chart-component-settings/src/lib/topology/componentSettings

To test all the settings you can change these default settings and reload on a backend without componentSettings.

Checklist

  • Make the title short and concise
  • Select the correct label to include it in the release notes:
    • rel: new feature
    • rel: improvement
    • rel: fixes
    • rel: ignore
      Select to rel: ignore if this pull request fixes a New Feature or Improvement in the coming release. Update related Pull Request.
  • Update documentation.
  • Update tests.

@hvangeffen hvangeffen self-assigned this Feb 3, 2025
@hvangeffen hvangeffen force-pushed the add-chart-component-settings branch from 6c4b3a2 to 9443c93 Compare February 3, 2025 08:45
@hvangeffen hvangeffen force-pushed the 1165-dwo-874-time-slider-dashboard branch from a41b635 to 9df1693 Compare February 3, 2025 08:46
@hvangeffen hvangeffen force-pushed the add-chart-component-settings branch from 9443c93 to d3ef0db Compare February 3, 2025 10:12
@hvangeffen hvangeffen force-pushed the 1165-dwo-874-time-slider-dashboard branch from fe88c50 to fc6334d Compare February 4, 2025 01:04
@hvangeffen hvangeffen force-pushed the add-chart-component-settings branch 2 times, most recently from 665475f to 2295220 Compare February 4, 2025 01:19
@hvangeffen hvangeffen force-pushed the 1165-dwo-874-time-slider-dashboard branch 2 times, most recently from fc8fbaf to 007b5e4 Compare February 6, 2025 07:07
Base automatically changed from 1165-dwo-874-time-slider-dashboard to main February 7, 2025 11:01
@hvangeffen hvangeffen force-pushed the add-chart-component-settings branch 2 times, most recently from e57a407 to 5a292d9 Compare February 11, 2025 00:57
@hvangeffen
Move component settings to seperate files and use new chartSettings
4f73edf
@hvangeffen
Use show settings for chart tabs
dd13f34
@hvangeffen
Add startpanel support
9a4490b
@hvangeffen
Move chart labels to seperate component and change align
3b09b2d
@hvangeffen
Add support for chart legend inside placement
e783bcc
@hvangeffen
Add support for vertical y label placement and vertical profile settings
7cf1958 
timeserieschart
@hvangeffen
Move axisOptions to lib and option for hiding x or y label
1dd26cc
@hvangeffen
Add option to hide ticks
c090753
@hvangeffen
Add setting to hide toolbar
1546627
@hvangeffen
Change overlay legend look
7145e16
@hvangeffen
Set chart height to 100% if less then 800px
8e4a49c
@hvangeffen
Fix multi line legend
7239072
@hvangeffen
Add timeSeriesWindowComponent to share logic between spatial and non
5bf5887 
spatial timeseriesdisplay's
@hvangeffen
Add setting to allow for time series table date sorting
fc55163
@hvangeffen
Remove rebase regression
602b782
@hvangeffen
Update pi-requests to 1.8.0
ba4e3c4
@hvangeffen
Get basemaps from general config
c8ae6d8
@hvangeffen
Use component settings types from pi-requests
a1d6587
@hvangeffen hvangeffen changed the title Add intial support for component settings with chart and report Add initial support for component settings with chart and report Feb 14, 2025
@hvangeffen hvangeffen force-pushed the add-chart-component-settings branch from 6c78731 to 7871440 Compare February 18, 2025 09:20
@hvangeffen hvangeffen force-pushed the add-chart-component-settings branch from 77869ff to 4572518 Compare February 18, 2025 10:18
@hvangeffen hvangeffen requested a review from wkramer February 18, 2025 13:16
@hvangeffen hvangeffen marked this pull request as ready for review February 18, 2025 13:19
@hvangeffen
Remove persist from baseMapStore as its setting is stored in
a6b7dfa 
userSettings
@hvangeffen
Fix overlay chart expand button size
4ee02ea
@hvangeffen
Allow oneOfMultiple to be updated later and storage value to be taken
c3cd858 
into account
@hvangeffen
Make overlay panel more compact and add title
00cb22e
@hvangeffen
In case of only overlay no wms show simple info panel
dd86c6a
@hvangeffen
Hide timeseries displaytype selection when only 1 is present
53310e9
@hvangeffen
Only show plotId selector when more then 1 plot id is present
c64ec90
@hvangeffen
Add small padding and increase minimum chart size
94e372b
@hvangeffen
Have chart margin react to axis.margin automargin changes
d658670
@hvangeffen
Make chart legend one per line and disabled hide svg
38e3ed8
@hvangeffen
Fix chart adding scrollbar when 100%
58cbcc7
@hvangeffen
Update pi-requests to 1.10.0
230c4f3
@hvangeffen
Fix timeseriesTable sort variables
9d6379c
@hvangeffen
Don't do tooltip request when panel is disabled
8a94967
@hvangeffen
Don't do timeseries requests when chart and table are disabled
cb3fcee
@hvangeffen
Fix vertical profile height
f57a199
@hvangeffen
Remove unused extra component settings
6b63d00
@hvangeffen
Add TODO's to unimplemented component settings
921e2c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkramer wkramer Awaiting requested review from wkramer

Assignees

@wkramer wkramer

@hvangeffen hvangeffen

Labels
rel: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvangeffen @wkramer