Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log display #1215

Draft
wants to merge 89 commits into
base: main
Choose a base branch
from
Draft

Add log display #1215

wants to merge 89 commits into from

Conversation

hvangeffen
Copy link
Collaborator

@hvangeffen hvangeffen commented Feb 20, 2025 •
edited
Loading

Description

Add log display for manual and system logs.
Groups them by taskRunId.

Remaining issues for later:

  • Maybe keep track of downloaded log message date range and on refresh only get new data from previous end date

Checklist

  • Make the title short and concise
  • Select the correct label to include it in the release notes:
    • rel: new feature
    • rel: improvement
    • rel: fixes
    • rel: ignore
      Select to rel: ignore if this pull request fixes a New Feature or Improvement in the coming release. Update related Pull Request.
  • Update documentation.
  • Update tests.

amarkensteijn and others added 30 commits February 11, 2025 02:30
@amarkensteijn @hvangeffen
Add empty operator log component to the system monitor display
efeb362
@amarkensteijn @hvangeffen
Add messages to data-iterator
f26190d
@amarkensteijn @hvangeffen
Add pagination
d861cbe
@amarkensteijn @hvangeffen
Add search
2d29e88
@amarkensteijn @hvangeffen
Correct log levels
4d6e9b2
@amarkensteijn @hvangeffen
Add filter options for user and log level
aaefe5c
@amarkensteijn @hvangeffen
Style cards more like chat messages
f24f9cf
@amarkensteijn @hvangeffen
Use different style for log message by the current user
351753f
@amarkensteijn @hvangeffen
Scroll instead of paginate
7fd5885 
Sort messages based on timestamp
@amarkensteijn @hvangeffen
Set color of message based on log level
f242398
@amarkensteijn @hvangeffen
Put timestamp next to user
ebf6125
@amarkensteijn @hvangeffen
Add icons
86c1a12
@amarkensteijn @hvangeffen
Expand message if it consists of multiple submessages
6d6164b
@amarkensteijn @hvangeffen
Cast type to any to ignore error, as casting to correct type is not p…
6d4067c 
…ossible

The isExpanded and toggleExpand expect a DataTableItem but log is a DataIteratorItem. Vuetify does not seem to export these types.
@amarkensteijn @hvangeffen
Fix search for array of messages
70df4e5
@amarkensteijn @hvangeffen
Add event codes to the log messages
ddb9309
@amarkensteijn @hvangeffen
Allow multiple selection in filter.
6d2b95b 
Empty filter means show all
@amarkensteijn @hvangeffen
Fix icon
7746329
@amarkensteijn @hvangeffen
Update types to reflect response from backend
153dc35 
For now, we will only deal with the default template for operator notes, which includes a single textfield. So we assume a single message.
@amarkensteijn @hvangeffen
Merge the different types of log messages, as the v-data-iteraor assu…
b6a4db0 
…mes all properties exist on all items
@amarkensteijn @hvangeffen
Filter on log type
04653e7
@amarkensteijn @hvangeffen
Link to topology node from log message
4105462
@amarkensteijn @hvangeffen
Make toolbar compact
0c06273
@amarkensteijn @hvangeffen
Option to add new message
0e0830c
@amarkensteijn @hvangeffen
Make the long message longer
36ff484
@hvangeffen
Cleanup operator log css
f473ae5
@hvangeffen
Add log display to route and use it for operator log
9f40bba
@hvangeffen
Get logdisplays from back end and move types to util
81280f9
@hvangeffen
Update pi requests to 1.5.3
988866c
@hvangeffen
Move log display to use function
bf27f27
@hvangeffen
Reduce url size taskruns
daa5f87
@hvangeffen
Change from v-expansion to plain v-if
25578f7
@hvangeffen
Rename logItem to logMessageItem
49cb7f9
@hvangeffen
Rename logExpander to logItem
eff2ae4
@hvangeffen
Rename logExpansion to logTable
07f6390
@hvangeffen
Rename logsComponent to logDisplayComponent
ec9da24
@hvangeffen
Make darkmode logtable background transparent
6dbfbfa
@hvangeffen
Remove unecessary manual virtual refresh
e92f113
@hvangeffen
Add bottom padding logs display
44d36c7
@hvangeffen
Fix filtering causing taskrun request
46a728a
@hvangeffen
Fix flickering logmessage component
f1447ec
@hvangeffen
Add taskrun utils
6a3ae4e
@hvangeffen
Add type guard task status
63de925
@hvangeffen
Get task status icon task run
71ad0b7
@hvangeffen
Add critical and error as seperate log filter options
5f72ba8
@hvangeffen
Remove unused console.log
fae96f3
@hvangeffen
Add whatif type for pi-requests update
be91c09
@hvangeffen
Add margin to top of table
9419903
@hvangeffen
Add color to log status
fc58e4d
@hvangeffen
Store whether a taskrun is expanded for virtual scroll
6ce739d
@hvangeffen
Remove unused variables
5918afe
@hvangeffen
Only show log type filter when both are defined
cb41905
@hvangeffen
Use 0s in case of no date difference
36aea23
@hvangeffen hvangeffen requested a review from wkramer February 20, 2025 08:32
@hvangeffen hvangeffen linked an issue Feb 20, 2025 that may be closed by this pull request
DWO-918: Opbouw logdisplay op basis van response get/logdisplay #1173
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkramer wkramer Awaiting requested review from wkramer

Assignees

@wkramer wkramer

@hvangeffen hvangeffen

Labels
rel: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DWO-918: Opbouw logdisplay op basis van response get/logdisplay
3 participants
@hvangeffen @wkramer @amarkensteijn