Currency conversion jrc #434
Conversation
There was a problem hiding this comment.
Nice! This will do the job. I think we can merge this but I would make another issue for how to handle the currency in general. I think there should be a currency unit class that includes the currency and the year. Then each dataset will have a currency defined in it (for example JRC will have EUR, 2010 etc.). Then for the conversions maybe we could use something like: https://github.com/MicroPyramid/forex-python. So the user would just provide the unit that they would like their exposure to be in, and then the conversion would be done automatically.
| @@ -339,6 +344,7 @@ def setup_buildings_from_multiple_sources( | |||
| bf_conversion: bool = False, | |||
| keep_unclassified: bool = True, | |||
| damage_translation_fn: Union[Path, str] = None, | |||
| eur_to_us_dollar: bool = None, | |||
There was a problem hiding this comment.
shouldn't the default value be False?
Yes I think thats a really nice idea! I hope we can implement this at one point!! |
|
convert jrc damage values from eur 2010 to US dollars 2010