Issue #1381 average well rates at steady state #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teady-state" for a steady-state simulation.
Manangka
reviewed
Jan 15, 2025
Manangka
approved these changes
Jan 16, 2025
|
JoerivanEngelen
deleted the
issue_#1381_average_well_rates_at_steady_state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1381
Description
Upon receiving simulation
timeswith string "steady-state"Well.from_imod5_datanow assumes the simulation is steady-state and well rates should be averaged.This brings well rates of packages a lot closer to what iMOD5 produces in the water balance for steady-state simulations.
GroundwaterFlowModel.from_imod5_datasetstimesarg forWell.from_imod5_datato"steady-state"if no Storage package is present in the projectfile.I opted for this for now as we currently lack of a clear API to construct steady-state simulations. See also #1308.
Checklist
Issue #nr, e.g.Issue #737