Issue #1395 Change default value for missing layers for angle1 #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See my comment in the issue: entering a value for ANGLE will likely slow MF6 down. Better to apply the trigonometry yourself. |
Manangka
approved these changes
Jan 30, 2025
imod/mf6/npf.py
Outdated
| @@ -510,7 +510,7 @@ def from_imod5_data( | |||
| angle1 = imod5_data["ani"]["angle"] | |||
| angle1 = 90.0 - angle1 | |||
| angle1 = xr.where(angle1 < 0, 360.0 + angle1, angle1) | |||
| angle1 = fill_missing_layers(angle1, target_grid, 0) | |||
| angle1 = fill_missing_layers(angle1, target_grid, 90) | |||
There was a problem hiding this comment.
Should be 90.0 to be consistent with the way other angles are written
There was a problem hiding this comment.
Nice catch, fixed!
|
Created a separate issue for this #1397 |
JoerivanEngelen
deleted the
issue_#1395_fill_layers_with_better_missing_value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1395
Description
Use proper value for missing layers in projectfile.
Checklist
Issue #nr, e.g.Issue #737