Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing duplicate registration issue #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing duplicate registration issue #1

wants to merge 1 commit into from

Conversation

dd-002
Copy link
Collaborator

@dd-002 dd-002 commented Jul 17, 2023

No description provided.

SanskarGosavi2003
SanskarGosavi2003 reviewed Jul 17, 2023
View reviewed changes
register.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we not using async here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dd-002

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanskarGosavi2003 which line exactly?

amitmalakariitb added a commit that referenced this pull request Jun 30, 2024
@amitmalakariitb
Merge pull request #1 from amitmalakariitb/notification
0ec9176 
Added notification model and controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanskarGosavi2003 SanskarGosavi2003 SanskarGosavi2003 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dd-002 @SanskarGosavi2003