Fix DateTime to DateTimeOffset conversion (#478)

DevExpress · Apr 26, 2021 · 833861b · 833861b
1 parent 3018ac3
commit 833861b
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/net/DevExtreme.AspNet.Data.Tests/FilterExpressionCompilerTypeConversionTests.cs b/net/DevExtreme.AspNet.Data.Tests/FilterExpressionCompilerTypeConversionTests.cs
@@ -1,4 +1,6 @@
-using System;
+using Newtonsoft.Json;
+using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
@@ -223,6 +225,24 @@ public void StringFuncOnTimeSpan() {
             AssertEvaluation(obj, new[] { "NullableTime", "contains", "23" });
         }
 
+        [Theory]
+        [InlineData(DateParseHandling.None)]
+        [InlineData(DateParseHandling.DateTime)]
+        [InlineData(DateParseHandling.DateTimeOffset)]
+        public void Issue477(DateParseHandling dateParseHandling) {
+            var date = new DateTimeOffset(2021, 1, 1, 0, 0, 0, TimeSpan.Zero);
+            var filterJSON = JsonConvert.SerializeObject(new object[] { "this", date });
+            var deserializedFilter = JsonConvert.DeserializeObject<IList>(filterJSON, new JsonSerializerSettings {
+                DateParseHandling = dateParseHandling
+            });
+
+            var loadOptions = new SampleLoadOptions {
+                Filter = deserializedFilter
+            };
+
+            var loadResult = DataSourceLoader.Load(new[] { date }, loadOptions);
+            Assert.Single(loadResult.data);
+        }
     }
 
 }
diff --git a/net/DevExtreme.AspNet.Data/Utils.cs b/net/DevExtreme.AspNet.Data/Utils.cs
@@ -47,6 +47,9 @@ public static object ConvertClientValue(object value, Type type) {
             if(type == typeof(DateTime) && value is String)
                 return DateTime.Parse((string)value, CultureInfo.InvariantCulture, DateTimeStyles.RoundtripKind);
 
+            if(type == typeof(DateTimeOffset) && value is DateTime date)
+                return new DateTimeOffset(date);
+
             var converter = TypeDescriptor.GetConverter(type);
             if(converter != null && converter.CanConvertFrom(value.GetType()))
                 return converter.ConvertFrom(null, CultureInfo.InvariantCulture, value);