Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update of client for api version 4.12.0+ #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kubascikmichal
Copy link

Client was not compatible with new API settings - lower version than 4.12.0 not supported, and over 4.12.0 require new headers.

@Splatjov
Copy link

it does not compiling for me, are you sure its working?

@kubascikmichal
Copy link
Author

I am sure - it worked for me. What error did you get?

@joeseegtatz
Copy link

When trying to build I get the error:

 @diakem/[email protected] build:types
> tsc --emitDeclarationOnly

src/client.ts:78:5 - error TS7053: Element implicitly has an 'any' type because expression of type '"account-id"' can't be used to index type 'HeadersDefaults'.
  Property 'account-id' does not exist on type 'HeadersDefaults'.

78     instance.defaults.headers['account-id'] = sha256(
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/client.ts:79:31 - error TS2339: Property 'user' does not exist on type 'LoginRedirectData | Data | StepData'.
  Property 'user' does not exist on type 'LoginRedirectData'.

79       loginResponse.data.data.user.id
                                 ~~~~


Found 2 errors.

@kubascikmichal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants