Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed from builder.aOut to builder.Action for commands #100

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

evalott100
Copy link
Contributor

@evalott100 evalott100 commented Dec 6, 2024

Closes #99

builder.Action is a wrapper to a boolOut with always_update=True. This is how PandaBlocks-ioc does it and will probably work with ophyd-async.

@dperl-dls can you please test this branch? (or if it's too much of a pain with updating alongside other changes then copy the line where I do aOut -> Action locally.

`builder.Action` is a wrapper to a `boolOut` with `always_update=True`.
This is how PandaBlocks-ioc does it and will probably work with
ophyd-async.
@evalott100 evalott100 self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.75%. Comparing base (baebfaa) to head (5708b39).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   87.75%   87.75%           
=======================================
  Files          28       28           
  Lines        1184     1184           
=======================================
  Hits         1039     1039           
  Misses        145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evalott100
Copy link
Contributor Author

Note that the pvi side doens't need to change:

return SignalX(
name=name,
write_pv=pv,
value="1",
write_widget=ButtonPanel(actions={name: "1"}),
)

Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks so much for the speedy response!

@GDYendell GDYendell merged commit 2153173 into main Dec 6, 2024
18 checks passed
@GDYendell GDYendell deleted the 99-fix-command-record branch December 6, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility between @command and ophyd-async epics_signal_x
3 participants