Add ZMQ Connection support #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## create-connections-dir #21 +/- ##
==========================================================
- Coverage 43.79% 41.32% -2.48%
==========================================================
Files 17 19 +2
Lines 653 772 +119
==========================================================
+ Hits 286 319 +33
- Misses 367 453 +86 ☔ View full report in Codecov by Sentry. |
OCopping
force-pushed
the
Add-zmq-connection-support
branch
from
86f9116 to
6843952
Compare
|
@OCopping can I assume this isn't ready to be reviewed until you remove the draft? |
OCopping
force-pushed
the
Add-zmq-connection-support
branch
from
3b802ae to
266d871
Compare
OCopping
force-pushed
the
create-connections-dir
branch
from
9b2414c to
ef559ec
Compare
…adding other connection type scripts
Renamed class attributes
…tion class; Updated code to use asyncio.TaskGroup() from Python 3.11
OCopping
force-pushed
the
Add-zmq-connection-support
branch
from
3bdfd8f to
682d97e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add an Asynchronous ZMQ Connection class to FastCS connections.