Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-117: Fix grid scan coordinates for snaked scans #709

Merged
merged 1 commit into from
Jan 12, 2024
Merged

LIMS-117: Fix grid scan coordinates for snaked scans #709

merged 1 commit into from
Jan 12, 2024

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Jan 4, 2024

JIRA ticket: LIMS-117

Summary:

The x/y/z coordinates displayed for a grid scan previously assumed the scan was not snaked.

Changes:

  • Fix xp or yp for snaked scans for horizontal or vertical scans
  • Minor whitespace change

To test:

  • Go to a snaked grid scan (eg /dc/visit/cm33903-1/id/10333286), click on a grid box in the first row, check the x coordinate. Click on the box below, check the x coordinate is the same
  • Repeat for a hyperion scan (eg /dc/visit/cm33866-5/id/12600850)
  • Repeat for a vertical scan (eg /dc/visit/cm33851-1/id/10034039)

@gfrn gfrn self-requested a review January 12, 2024 09:00
@ndg63276 ndg63276 merged commit 1d10ac9 into prerelease Jan 12, 2024
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-117/incorrect-grid-scan-coordinates branch January 12, 2024 09:32
gfrn pushed a commit that referenced this pull request Feb 26, 2024
@ndg63276 @gfrn
LIMS-117: Fix grid scan coordinates for snaked scans (#709)
2f90273 
Co-authored-by: Mark Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfrn gfrn gfrn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @gfrn