LIMS-1496: Fix offset grid scan heatmaps in Safari #896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1496
Summary:
When viewing vertical grid scans in Safari, the image is offset and so the heatmap doesn't align with the drawn grid. This seems to be because Safari doesn't like negative numbers being passed to drawImage. To test this, go to https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_canvas_drawimage and replace the drawImage line with
On Firefox or Chrome, you see a squashed image in the right half of the frame. On Safari, you see the normal image.
It turns out Safari doesn't like negative values for the second parameter (sx), so it ignores them and uses 0 instead. It also doesn't like if sx + swidth is larger than the source image width, and scales down swidth to compensate. (Firefox and Chrome just extend the source image).
Changes:
To test:
Before:
After:
Before:
After: