Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBA Changes #31

Merged
merged 27 commits into from
Sep 5, 2024
Merged

BBA Changes #31

merged 27 commits into from
Sep 5, 2024

Conversation

T-Nicholls
Copy link
Collaborator

Changes made while attempting to get BBA to interface with the virtac.

@T-Nicholls
Copy link
Collaborator Author

The Python 3.7 build is failing due to pytest-flake8 which is abandoned, it's not worth fixing it on its own as it'd be resolved whenever we move ATIP over to the Diamond pip-skeleton/ copier template/new deployment system.

@garryod garryod requested a review from coretl July 15, 2024 11:19
@coretl coretl removed their request for review July 15, 2024 18:06
virtac/atip_ioc_entry.py Outdated Show resolved Hide resolved
atip/simulator.py Show resolved Hide resolved
virtac/atip_ioc_entry.py Outdated Show resolved Hide resolved
virtac/atip_ioc_entry.py Outdated Show resolved Hide resolved
Copy link

@MJGaughran MJGaughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're able to be more explicit about the cause of errors with other cothread applications, I would suggest adding that but otherwise this PR is good.

@T-Nicholls
Copy link
Collaborator Author

I don't think I can elaborate concisely on the issue with other cothread applications.

Side note, I noticed that the fix for the issue in AT that was blocking us from making I04 the default ring mode got merged, so I've updated it and snuck it on the end of this pr.

Also, for some reason, I don't have merge permissions for this repo or Pytac, but I do for dls-bba

@T-Nicholls T-Nicholls merged commit dc56ca7 into DiamondLightSource:master Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants