Add plots #27
Add plots #27
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 5 +1
Lines 95 157 +62
=========================================
+ Hits 95 157 +62 ☔ View full report in Codecov by Sentry. |
| @@ -54,12 +58,76 @@ def calculate_voltages( | |||
| ) | |||
|
|
|||
|
|
|||
| def calculate_optimal_voltages(file_path: str) -> np.typing.NDArray[np.float64]: | |||
There was a problem hiding this comment.
Could: use the pathlib library instead of strings to represent paths. Might be overkill, but could simplify the validation and logic you're doing in this file to manipulate strings representing paths. Also gives a nicer function signature eg: def read_bluesky_plan_output(filepath: str): .. vs def read_bluesky_plan_output(filepath: Path): ...
There was a problem hiding this comment.
added a ticket to do this. will implement once core functionality for the in-lab tests are completed
| @@ -54,12 +58,76 @@ def calculate_voltages( | |||
| ) | |||
|
|
|||
|
|
|||
| def calculate_optimal_voltages(file_path: str) -> np.typing.NDArray[np.float64]: | |||
There was a problem hiding this comment.
Should: Add docstring
|
Must add traces for both vltage calculations before merging. This requires the completion of #31 |
adding plot functionality and integrating into cli