Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include convenience bash script for running rabbit mq locally #668

Conversation

Relm-Arrowny
Copy link
Contributor

fix #615

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (a33daa2) to head (c30b44e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
- Coverage   92.35%   92.30%   -0.06%     
==========================================
  Files          35       35              
  Lines        1793     1793              
==========================================
- Hits         1656     1655       -1     
- Misses        137      138       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks! Just a few small changes.

src/script/stomp_config.yml Outdated Show resolved Hide resolved
src/script/rabbitmq_setup/Dockerfile Outdated Show resolved Hide resolved
docs/tutorials/quickstart.md Outdated Show resolved Hide resolved
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came here after not being able to get ActiveMQ to work but this works great, thanks! Some comments in code though. Particularly I think the path issue is important

docs/tutorials/quickstart.md Show resolved Hide resolved
docs/tutorials/quickstart.md Outdated Show resolved Hide resolved
docs/tutorials/quickstart.md Show resolved Hide resolved
@callumforrester
Copy link
Contributor

@Relm-Arrowny main is fixed if you want to try rebasing

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments on the docs are addressed by #674, thanks @callumforrester

@callumforrester
Copy link
Contributor

The sonarcloud error should be fixed by #664
Once that's merged could you rebase on top of it to check it works?

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Relm-Arrowny and others added 3 commits November 4, 2024 14:59
…cally' of github.com:Relm-Arrowny/blueapi into Include-convenience-bash-script-for-running-RabbitMQ-locally
@Relm-Arrowny Relm-Arrowny merged commit 5abe34a into DiamondLightSource:main Nov 4, 2024
15 checks passed
@Relm-Arrowny Relm-Arrowny deleted the Include-convenience-bash-script-for-running-RabbitMQ-locally branch November 4, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include convenience bash script for running RabbitMQ locally
4 participants