-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include convenience bash script for running rabbit mq locally #668
Include convenience bash script for running rabbit mq locally #668
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
==========================================
- Coverage 92.35% 92.30% -0.06%
==========================================
Files 35 35
Lines 1793 1793
==========================================
- Hits 1656 1655 -1
- Misses 137 138 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks! Just a few small changes.
…script-for-running-RabbitMQ-locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came here after not being able to get ActiveMQ to work but this works great, thanks! Some comments in code though. Particularly I think the path issue is important
@Relm-Arrowny |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments on the docs are addressed by #674, thanks @callumforrester
The sonarcloud error should be fixed by #664 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…cally' of github.com:Relm-Arrowny/blueapi into Include-convenience-bash-script-for-running-RabbitMQ-locally
fix #615