Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of fixtures with direct calls to functions #82

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Replace use of fixtures with direct calls to functions #82

merged 1 commit into from
Feb 6, 2025

Conversation

tpoliaw
Copy link
Collaborator

@tpoliaw tpoliaw commented Feb 5, 2025 •
edited by abbiemery
Loading

Fixes #81

@tpoliaw tpoliaw requested a review from abbiemery February 6, 2025 11:49
abbiemery
abbiemery approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels better to me. It is more explicit and more consistent. My comments are just me asking for learning purposes.

src/db_service.rs Show resolved Hide resolved
src/db_service.rs Show resolved Hide resolved
@tpoliaw tpoliaw merged commit 248845d into main Feb 6, 2025
4 checks passed
@tpoliaw tpoliaw deleted the de-fixture branch February 6, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbiemery abbiemery abbiemery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor tests
2 participants
@tpoliaw @abbiemery