Use a temp file for read-only DB tests #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This kind of feels like an overkill just to test that sqlite errors are propagated back to the client. Maybe going back to the missing table version would be easier |
An in-memory DB does not allow a mix of read-only and read-write connections. The initial connection has to have write access to set up the initial schema so subsequent connections all end up having write access as well, even when setting read_only(true) in the pool options. The read_only test previously passed as the connection in the test was seeing a new in-memory database and the test didn't distinguish between 'DB is read-only' and 'Table does not exist' error cases.
tpoliaw
force-pushed
the
read_only_temp_db
branch
from
d92c55a to
8720efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An in-memory DB does not allow a mix of read-only and read-write
connections. The initial connection has to have write access to set up
the initial schema so subsequent connections all end up having write
access as well, even when setting read_only(true) in the pool options.
The read_only test previously passed as the connection in the test was
seeing a new in-memory database and the test didn't distinguish between
'DB is read-only' and 'Table does not exist' error cases.