-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "status" and "severity" on In record init #111
Conversation
Add new tests and refactor existing ones Add docs
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 87.64% 87.03% -0.61%
==========================================
Files 14 14
Lines 963 972 +9
==========================================
+ Hits 844 846 +2
- Misses 119 126 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Unit Test Results 15 files ± 0 15 suites ±0 29m 51s ⏱️ - 1m 5s Results for commit dc4a63f. ± Comparison against base commit 3f0ec72. This pull request removes 1 and adds 18 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straightforward. Probably worth making the one mentioned change.
This stops us from accidentally overriding a "STAT" value if there's also "status" defined, for example
This PR allows users to specify
severity
andstatus
on record initialization, with values from thesoftioc.alarm
module.Note that "PINI" is set to "YES" by default, which means that the alarm status is immediately reset when the IOC is initialized. I'm not sure if we need to do anything fancy like disable "PINI" when we spot a
status
orseverity
keyword?Closes #57