Remove python2 support #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is parked until #63 is merged and released, then this branch will need to be rebased. |
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 85.37% 85.38%
=======================================
Files 13 13
Lines 834 814 -20
=======================================
- Hits 712 695 -17
+ Misses 122 119 -3
Continue to review full report at Codecov.
|
As we don't have Black formatter running, this at least provides some of the functionality without breaking any existing formatting.
Turns out I hadn't saved the file before previous commit...
Araneidae
force-pushed
the
remove_python2
branch
from
4cec9e1 to
878ebac
Compare
Araneidae
reviewed
Nov 30, 2021
|
@Araneidae I've made all the changes requested, and CI is now passing. Please let me know if this is good to merge. It seems the previous error is a transient problem with codecov that disappeared on re-runs. |
Araneidae
reviewed
Nov 30, 2021
|
Looks good to me. |
Araneidae
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardises Python 3.6 as the lowest supported version of Python, dropping support for Python 2.7.
3.6 was chosen as that's where our CI runs tests, although it wasn't declared as such in the setup.cfg until I edited it. If this should actually be Python3.7 we should also remove 3.6 from CI.
I have removed all references to 2.7, mostly by removing all Python version checking code, and done some fairly trivial refactoring where appropriate.
This also adds some auto-formatting of whitespace/newlines on save to VSCode, as we don't use an autoformatter.
Closes #61