git - Merge pull request #89 from DinoTools/fix_bool_issue

Fix issue with bool values
DinoTools · Jul 15, 2024 · 9836f60 · 9836f60
2 parents 0673063 + 2250d70
commit 9836f60
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/routeros_check/resource.py b/routeros_check/resource.py
@@ -335,7 +335,12 @@ def get_routeros_metric_item(
                     logger.warning(f"Error parsing value with name {metric_value_name}", exc_info=True)
                     raise e
 
-            value = value * metric_value.get("factor", 1)
+            value_factor = metric_value.get("factor")
+            if value_factor is not None:
+                if isinstance(value, bool):
+                    logger.warning(f"Unable to use factor with bool metric {metric_value_name}", exc_info=True)
+                    raise ValueError(f"Unable to use factor with bool metric {metric_value_name}")
+                value = value * value_factor
 
             extra_kwargs = {}
             for n in ("min", "max", "uom"):