rename onclick_only to provided_onclick_only in dioxus_router's Link #1617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise it doesn't work :)
this is needed to allow cmd-clicking link. working example:
btw, what would you say if I add this example code to Link as well? (in a separate PR). I think it's important to allow cmd-click for opening in new tabs. I only ever worked with Liveview though, so may be missing somethingactually,
window.open
doesn't allow the focus to be retained in the original tab anymore. so without someprevent_default
hackery, I'll have to resort to the normala
here. anyway, this particular PR might still be of value, if this attribute is to be around