Select reasonable values from g.snapEnds() #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g.raphael seems to select strange values for the axis limits. This commit edits the code for g.snapEnds to make it simpler and pick sane numbers for the axis limits:
Thanks to Drew Noakes and his algorithm posted at http://stackoverflow.com/questions/326679/choosing-an-attractive-linear-scale-for-a-graphs-y-axis, which I adapted into g.snapEnds(). In my case, with a time-series dataset, the values for the axis were being selected outside the timeframe of the data. Therefore, the graph was plotted outside the graph area on both sides of the graph. This algorithm selects axis ends that are outside the dataset, is simple, and likely much faster.