New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle keyboard navigation #6

Open

dev-nicolaos wants to merge 2 commits into DoctorBracewell:master from dev-nicolaos:handle-keyboard-navigation

dev-nicolaos commented Oct 11, 2023 •

edited

Loading

@DoctorBracewell this PR makes a couple changes to allow the site to be navigated with a keyboard:

changes non-link click targets to HTML <button>s
- allows them to be focused and provides built-in space and enter key handlers
manages focus for the song selection modal
- sends focus to first focus-able element (first song) on open
- makes the rest of the app inert while open to trap focus within the modal
- sends focus back to modal trigger when modal is closed

dev-nicolaos added 2 commits

October 11, 2023 06:55


          use buttons for controls

67448f7


          handle modal focus

c862f4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet