spec: allow number types to be ints, strings, and/or variables #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this change numbers are always quoted after reformatting. That is the
only way to be somewhat consistent what is the representation format when
%variables% need to be supported, and they need to be strings.
As a practical example, one could have the following in a template (and it
would fail, but it's obvious why - see the hostname).
"records": [
{
"type": "A",
"host": "the-ttl-is-plain-number-this-is-ok",
"ttl": 1800
},
{
"type": "A",
"host": "the-ttl-is-quoted-number-this-is-ok",
"ttl": "8100"
},
{
"type": "A",
"host": "the-ttl-is-variable-this-is-ok",
"ttl": "%varttl%"
},
{
"type": "A",
"host": "ttl-is-BROKEN-it-cannot-be-just-a-string",
"ttl": "just-a-string"
}
]
Reference: Domain-Connect/spec#100
Signed-off-by: Sami Kerola <[email protected]>
The version number must be unsigned integer. Anything else is just too difficult to deal with. Signed-off-by: Sami Kerola <[email protected]>
kerolasa
force-pushed
the
kerolasa/string-interger-variable
branch
from
c54a052 to
5934b51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change numbers are always quoted after reformatting. That is the only way to be somewhat consistent what is the representation format when %variables% need to be supported, and they need to be strings.
As a practical example, one could have the following in a template (and it would fail, but it's obvious why - see the hostname).
Reference: Domain-Connect/spec#100