fix: file writing is canceled for ANY errors #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Emann
force-pushed
the
push-ptqnxtoqvwyq
branch
from
402e8a7 to
ab80d9b
Compare
This ensures that unless we signal full success in the reader (and for each slot), the writer will not promote the file. For example, if the file changed sizes while reading, it will now properly be ignored.
Dr-Emann
force-pushed
the
push-ptqnxtoqvwyq
branch
from
ab80d9b to
cb8302e
Compare
Merged
|
Fully fixes #98 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that unless we signal full success in the reader (and for each slot), the writer will not promote the file.
For example, if the file changed sizes while reading, it will now properly be ignored.