Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Outlines #267

Open
wants to merge 1 commit into
base: act-2-bevy
Choose a base branch
from
Open

feat: Outlines #267

wants to merge 1 commit into from

Conversation

Lubba-64
Copy link

@Lubba-64 Lubba-64 commented Feb 14, 2025

Closes #247

@Lubba-64
Copy link
Author

I need some overview with the items but I set up the consorts. I do not actually know how the item system works, or how to use the inventory or anything. I had to use and thoroughly debug bevy_mod_outline to get this to work, because that crate is better at outlines for single entities and not for the whole screen.

@Lubba-64 Lubba-64 requested a review from jwright159 February 14, 2025 23:02
@jwright159
Copy link
Collaborator

The inventory system isn't too bad. It's just a Vec and a component called Item that's only on one object rn

Copy link
Collaborator

@jwright159 jwright159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall we still gotta discuss what kinda outlines we want and what we need for it

#[cfg(feature = "overview_camera")]
overview_camera::OverviewCameraPlugin,
bevy_hanabi::HanabiPlugin,
OutlinePlugin,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular line should not be indented... Do you have cargo fmt and format-on-save?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stuffs broken on windows. cant fix rn, will do cargo fmt and commit.

Comment on lines +70 to +78
#[cfg(feature = "rapier_debug")]
RapierDebugRenderPlugin::default(),
#[cfg(feature = "inspector")]
bevy_inspector_egui::quick::WorldInspectorPlugin::new(),
#[cfg(feature = "overview_camera")]
overview_camera::OverviewCameraPlugin,
EdgeDetectionPlugin::default(),
RapierPhysicsPlugin::<NoUserData>::default(),
bevy_hanabi::HanabiPlugin,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had these set up in the above add_plugin so we wouldn't run into issues in having too many tuple elements

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this doesn't even compile

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does for me, I will fix this, I know what I changed.

SpawnQuestMarker,
SpawnNameTag,
));
let mut id = None;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a way better way to get child Entities. Just call let id = commands.spawn(...).set_parent(ev.entity).id();

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Lubba-64
Copy link
Author

Will get to this sometime this week? we're rolling a sobel filter with selection and customization to whatever entities we want to have a post-processing outline for.

@@ -102,6 +106,52 @@ pub fn interact_with<T: Component>(
},
);

if let Some((Some(entity), _)) = hit_entity {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW there is some flickering in the selection here.... any ideas why? I'll have to debug this sooner or later....

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its only every other time I run the game too which sucks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did see that, I have NO idea-- oh wait it's probably system run order race condition stuff. run the shader system after = whatever_the_interact_system_is_called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Add bevy_edge_detection for stylization and also item outlines
2 participants