Implement submodules per unique scene #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettchalupa
requested changes
May 20, 2024
| GameplayScene.tick(args) | ||
| end | ||
|
|
||
| module GameplayScene |
There was a problem hiding this comment.
Would you mind indenting all of these modules and their associated code one level? It'll make it easier to know it's a submodule of Scene
There was a problem hiding this comment.
I did that at first, but afterwards git kind of mangled the changes a little bit in a disruptive way. So it looks like the whole file gets replaced when it's not supposed to. It breaks git blame and so on. Any suggestions how to proceed?
There was a problem hiding this comment.
@Anthogonyst you should be able to indent it, commit those changes, and it should be all set! Let me know if you want any support with that. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #8 , I created an internal module so that each scene has a generic tick method and an unique namespace. Cheers.