Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Staggered] fix order sizing when no recent trades are available #1428

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

GuillaumeDSM
Copy link
Member

No description provided.

@GuillaumeDSM GuillaumeDSM requested a review from Herklos January 27, 2025 21:03
@GuillaumeDSM GuillaumeDSM self-assigned this Jan 27, 2025
@GuillaumeDSM GuillaumeDSM enabled auto-merge (rebase) January 27, 2025 21:04
Copy link
Member

@Herklos Herklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1594,10 +1594,9 @@ def _get_surrounded_missing_order_quantity(
min(
data_util.mean([previous_order.origin_quantity, following_order.origin_quantity])
if following_order else previous_order.origin_quantity,
max_quant_per_order / order_price
(max_quant_per_order if selling else max_quant_per_order / order_price)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@GuillaumeDSM GuillaumeDSM merged commit 3df16bf into dev Jan 27, 2025
5 checks passed
@GuillaumeDSM GuillaumeDSM deleted the staggered_fix branch January 27, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants