[Coinbase] handle UnexpectedDER

Drakkar-Software · May 24, 2024 · a0c2afb · a0c2afb
1 parent 9fd4bfb
commit a0c2afb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/tests/exchanges/test_coinbase.py b/tests/exchanges/test_coinbase.py
@@ -75,6 +75,12 @@ async def test_invalid_api_key_get_api_key_rights(coinbase_exchange):
         exchange._exchange.connector.client.apiKey = "-----BEGIN EC PRIVATE KEY----b43c5889-a3b5-4ab5-a606-578b4d74f3db"
         exchange._exchange.connector.client.secret = "-----BEGIN EC PRIVATE KEY-----\nMHcCAQEEIK/XmQtNSTD2pqrhyZFvBuExnlyLOPcDzT+fsm1sq3ZCoAoGCCqGSM49\nAwEHoUQDQgAErQXGFQUMqPT5fQUVcCchCaomapu0y952+XgveL2QjgghGCeFbLfR\nTSg2RgUUtGbG3TIBEomwzbRAOEeYdjK06w"
         assert await exchange._get_api_key_rights()
+    with pytest.raises(ccxt.AuthenticationError):
+        # added chars after private key
+        # ccxt.static_dependencies.ecdsa.der.UnexpectedDER turned into ccxt.AuthenticationError
+        exchange._exchange.connector.client.apiKey = "organizations/1e7665a0-440b-495f-8a49-5365841e196e/apiKeys/b43c5889-a3b5-4ab5-a606-578b4d74f3db"
+        exchange._exchange.connector.client.secret = "-----BEGIN EC PRIVATE KEY-----\nMHcCAQEEIK/XmQtNSTD2pqrhyZFvBuExnlyLOPcDzT+fsm1sq3ZCoAoGCCqGSM49\nAwEHoUQDQgAErQXGFQUMqPT5fQUVcCchCaomapu0y952+XgveL2QjgghGCeFbLfR\nTSg2RgUUtGbG3TIBEomwzbRAOEeYdjK06w" + b'488347'.decode()
+        assert await exchange._get_api_key_rights()
 
 
 # @pytest.mark.asyncio

diff --git a/trading_backend/exchanges/coinbase.py b/trading_backend/exchanges/coinbase.py
@@ -14,6 +14,7 @@
 #  You should have received a copy of the GNU Lesser General Public
 #  License along with this library.
 import ccxt
+import ccxt.static_dependencies.ecdsa.der
 import binascii
 import trading_backend.exchanges as exchanges
 import trading_backend.enums
@@ -113,7 +114,10 @@ async def _get_api_key_rights(self) -> list[trading_backend.enums.APIKeyRights]:
             return await self._get_api_key_rights_using_order()
         except ccxt.AuthenticationError:
             raise
-        except (binascii.Error, AssertionError, IndexError, ccxt.ArgumentsRequired) as err:
+        except (
+            binascii.Error, AssertionError, IndexError,
+            ccxt.ArgumentsRequired, ccxt.static_dependencies.ecdsa.der.UnexpectedDER
+        ) as err:
             raise ccxt.AuthenticationError(f"Invalid key format ({err})")
         except ccxt.BaseError as err:
             self._exchange.logger.exception(