Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bingx #49

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Bingx #49

merged 2 commits into from
Jan 24, 2024

Conversation

GuillaumeDSM
Copy link
Member

@GuillaumeDSM GuillaumeDSM commented Jan 23, 2024

No description provided.

@GuillaumeDSM GuillaumeDSM requested a review from Herklos January 23, 2024 23:03
@GuillaumeDSM GuillaumeDSM self-assigned this Jan 23, 2024
Copy link
Member

@Herklos Herklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +32 to +34
# It is currently impossible to fetch api key permissions: try to cancel an imaginary order,
# if a permission error is raised instead of a cancel fail, then trading permissions are missing.
# updated: 24/01/2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rights.append(trading_backend.enums.APIKeyRights.FUTURES_TRADING)
return rights

# todo use this when available (current issue is that ccxt bingx sign() requires "v1" to be the second value of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuillaumeDSM GuillaumeDSM merged commit 6cf830d into master Jan 24, 2024
6 checks passed
@GuillaumeDSM GuillaumeDSM deleted the bingx branch January 24, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants