improve keycloak sync #697
Open
+91
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isak-Kallini
force-pushed
the
improve-keycloak-sync
branch
2 times, most recently
from
bcfcec3 to
1758400
Compare
|
Is it worth keeping track of when things were last synced, as opposed to just syncing everything? On the one hand, I think we had some performance issues when we tried to just sync everything in one large batch, since it effectively caused a denial-of-service attack on our Keycloak instance. On the other hand, attempting to sync smartly makes it very easy for the systems to drift out of sync. |
|
There are currently 6432 entries in the mandates table, and it will just keep increasing so I think it's not sustainable to sync everything. |
Isak-Kallini
force-pushed
the
improve-keycloak-sync
branch
from
1758400 to
f7a7cbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a last_synced field to the mandates table and checks if a mandate has started or ended since the last time it synced and adds/deletes the user from the keycloak group.