feat: add config and issue tx methods #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonDuala
reviewed
Mar 24, 2024
DonDuala
reviewed
Mar 24, 2024
src/stakingOptions.ts
Outdated
| const userSoAccount = getAssociatedTokenAddressSync(optionMint, recipient, true); | ||
| const transaction = new Transaction(); | ||
|
|
||
| if (!(await this.connection.getAccountInfo(userSoAccount))) { |
There was a problem hiding this comment.
Similar question as above, since we handle this on the UI side currently, do we want to move that here? I would expect to also see mention of a PR with the app changes?
There was a problem hiding this comment.
Had held back on that PR since it wouldn't pass CI as-is but can open it 👍
brittcyr
reviewed
Mar 26, 2024
brittcyr
reviewed
Mar 26, 2024
DonDuala
approved these changes
Mar 28, 2024
brittcyr
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds configs and issue transaction methods that include setup instructions, this is meant to abstract burden on consumers to know which accounts need to be created for account validation in instructions (
quoteMinttoken account for config andsoMinttoken account for issue).Testing
This is being tested by
yarn linking to the main app and evaluating preflights for respective UI.