engines/splice: remove buggy ->mem_align set

Two things wrong here: 1) We align buffers by default, so no need for splice to do anything extra. 2) ->mem_align is not a true/false setting, it's the alignment itself. Hence the current setting to 1 is just buggy. Fixes: axboe#810 Reported-by: Sitsofe Wheeler <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
Dummyc0m · Aug 3, 2019 · 8ca8a05 · 8ca8a05
1 parent f2d6de5
commit 8ca8a05
Showing 1 changed file with 0 additions and 7 deletions.
diff --git a/engines/splice.c b/engines/splice.c
@@ -278,13 +278,6 @@ static int fio_spliceio_init(struct thread_data *td)
 	 */
 	sd->vmsplice_to_user_map = 1;
 
-	/*
-	 * And if vmsplice_to_user works, we definitely need aligned
-	 * buffers. Just set ->odirect to force that.
-	 */
-	if (td_read(td))
-		td->o.mem_align = 1;
-
 	td->io_ops_data = sd;
 	return 0;
 }