[FYI: GDiR] Inspect cbn code for referenced assemblies #10967
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparajit-pratap
commented
Aug 5, 2020
| @@ -336,6 +336,8 @@ private static bool CompileCodeBlockAST(Core core, ParseParam parseParams, IDict | |||
| reWrittenNodes = MigrationRewriter.MigrateMethodNames(reWrittenNodes, priorNames, core.BuildStatus.LogDeprecatedMethodWarning); | |||
| } | |||
|
|
|||
| ParserUtils.AssemblyDetector.GetAssemblyFromCodeBlock(core.ClassTable, reWrittenNodes); | |||
There was a problem hiding this comment.
This is the main method to call for a CBN. At the moment this is being called from within DynamoCore itself where it has access to the AST's parsed from the CBN (namely, rewrittenNodes) as well as the VM classtable.
aparajit-pratap
commented
Aug 5, 2020
| public override bool VisitIdentifierListNode(IdentifierListNode node) | ||
| { | ||
| var className = node.LeftNode.ToString(); | ||
| var assembly = CoreUtils.GetAssemblyFromClassName(classTable, className); |
There was a problem hiding this comment.
This utility method retrieves the assembly name from the classname used in the CBN script.
aparajit-pratap
changed the title
QilongTang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sample code to demonstrate querying CBN AST's for the assembly corresponding to the function calls in the code. This can be used for example, in determining host (Revit) API assemblies which are referenced in the CBN code.
The following is an example of CBN containing a call to a MeshToolkit method. The assembly referenced is
MeshToolkit.dll.Declarations
Check these if you believe they are true
*.resxfilesFYIs
@LongNguyenP @saintentropy @varvaratou