Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7779 Single dialog for download consent across different compatibility cases #15754

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jan 13, 2025

Purpose

Right now, Dynamo Package Manager client gives download consent in lots of different cases. This PR aims to unify a single dialog for download consent across different compatibility cases to be the first step of user clicking download.

Compatible:
image

Unknown Compatibility:
image

InCompatible:
image

When compatibility info exist, do not show any host dependency conflicts

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Single dialog for download consent across different compatibility cases

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added DNM Do not merge. For PRs. WIP labels Jan 13, 2025
@QilongTang QilongTang requested a review from hwahlstrom January 13, 2025 16:50
@QilongTang QilongTang marked this pull request as ready for review January 16, 2025 21:46
@QilongTang QilongTang removed DNM Do not merge. For PRs. WIP labels Jan 16, 2025
@QilongTang
Copy link
Contributor Author

Got legal approval, proceed to review state

@QilongTang QilongTang changed the title Single dialog for download consent across different compatibility cases DYN-7704 Single dialog for download consent across different compatibility cases Jan 16, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7704

Copy link

github-actions bot commented Jan 17, 2025

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang
Copy link
Contributor Author

QilongTang commented Jan 17, 2025

@QilongTang QilongTang merged commit 91399ef into master Jan 17, 2025
24 checks passed
@QilongTang QilongTang deleted the UnifyPackageDownloadConsent branch January 17, 2025 14:48
@QilongTang
Copy link
Contributor Author

All checks passed merging

@QilongTang QilongTang added this to the 3.5 milestone Jan 17, 2025
@avidit avidit changed the title DYN-7704 Single dialog for download consent across different compatibility cases DYN-7779 Single dialog for download consent across different compatibility cases Jan 17, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants