Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-4361: Enabling Ctrl+C for node previews within Dynamo #15791

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EdwardChaplinArchilizer
Copy link

@EdwardChaplinArchilizer EdwardChaplinArchilizer commented Jan 29, 2025

Purpose

Draft PR.

This PR is intended to add the ability to CTRL+C selected text within node preview dropdowns and watch nodes. As detailed here: https://jira.autodesk.com/browse/DYN-4361

image

Achieved by replacing the TextBlock with a TextBox and turning off the TextBox background/border whilst making it ReadOnly so that it resembles a TextBlock and enables CTRL+C.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Draft PR.

Making Ctrl + C work to copy selected data out of preview bubbles/watch nodes

Reviewers

@dnenov
@achintyabhat
@QilongTang

FYIs

@Amoursol

@github-actions github-actions bot changed the title Enabling Ctrl+C for node previews within Dynamo DYN-4361: Enabling Ctrl+C for node previews within Dynamo Jan 29, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-4361

@reddyashish
Copy link
Contributor

I think making it a TextBox will affect the up/down arrow navigation of the results in the preview bubble. That is the reason we did not make this change. Can you verify that?

@johnpierson
Copy link
Member

This will affect that unless some additional handlers are added. https://jira.autodesk.com/browse/DYN-7978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants