Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamo 3.0] Fix typo: recieved -> received #9516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nonoesp
Copy link
Contributor

@nonoesp nonoesp commented Feb 25, 2019

Purpose

Rename typos where received was typed as recieved. This should be a minor change, but there's a breaking change after renaming OnNotificationReceived (currently OnNotificationRecieved).

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

@nonoesp nonoesp added bug low hanging fruit relatively simple to implement and removed bug labels Feb 25, 2019
@mjkkirschner
Copy link
Member

Hi @nonoesp thanks for fixing this - unfortunately we can't break a public API like this (thanks for noting it - though I think that sem var check box should not be checked)

I think we'll have to fix this like:
#9170

@nonoesp
Copy link
Contributor Author

nonoesp commented Feb 25, 2019

Thanks for taking a look @mjkkirschner. That makes more sense.

@QilongTang
Copy link
Contributor

@mjkkirschner Moving forward, how do we deal with PRs like this? Shall we mark this one as DNM and put in the Dynamo 3.0 bucket?

@QilongTang QilongTang added the DNM Do not merge. For PRs. label Feb 26, 2019
@mjkkirschner
Copy link
Member

Thats fine with me.

@QilongTang QilongTang changed the title Fix typo: recieved -> received [Dynamo 3.0] Fix typo: recieved -> received Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM Do not merge. For PRs. low hanging fruit relatively simple to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants