Update Dynamo Core to 3.3.0.6316 and publish

.version

@@ -1 +1 @@
-0.6.26
+0.6.27

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.6.27
+* Update Dynamo Core to 3.3.0.6316
+* Add node documentation: Parameter, Element, Room, Material, Views 
+
 ## 0.6.26
 * Use new function to get translated string of Warning Severity
 

src/AssemblySharedInfoGenerator/AssemblySharedInfo.tt

@@ -70,7 +70,7 @@ using System.Runtime.InteropServices;
 [assembly: AssemblyFileVersion("<#= this.MajorVersion #>.<#= this.MinorVersion #>.<#= this.BuildNumber #>.<#= this.RevisionNumber #>")]
 <#+
 int MajorVersion = 3;
-int MinorVersion = 2;
-int BuildNumber = 2;
+int MinorVersion = 3;
+int BuildNumber = 0;
 int RevisionNumber = ((int)(DateTime.UtcNow - new DateTime(2024,1,1)).TotalDays)*10+((int)DateTime.UtcNow.Hour)/3;
 #>

src/Config/packages.aget

@@ -2,13 +2,13 @@
   "nuget": {
     "references": {
       "DynamicLanguageRuntime": "1.2.2",
-      "DynamoVisualProgramming.Core": "3.2.2.5494",
-      "DynamoVisualProgramming.DynamoCoreNodes": "3.2.2.5494",
-      "DynamoVisualProgramming.DynamoServices": "3.2.2.5494",
-      "DynamoVisualProgramming.Tests": "3.2.2.5494",
-      "DynamoVisualProgramming.WpfUILibrary": "3.2.2.5494",
-      "DynamoVisualProgramming.ZeroTouchLibrary": "3.2.2.5494",
-      "DynamoVisualProgramming.DynamoSamples": "3.2.2.5494",
+      "DynamoVisualProgramming.Core": "3.3.0.6316",
+      "DynamoVisualProgramming.DynamoCoreNodes": "3.3.0.6316",
+      "DynamoVisualProgramming.DynamoServices": "3.3.0.6316",
+      "DynamoVisualProgramming.Tests": "3.3.0.6316",
+      "DynamoVisualProgramming.WpfUILibrary": "3.3.0.6316",
+      "DynamoVisualProgramming.ZeroTouchLibrary": "3.3.0.6316",
+      "DynamoVisualProgramming.DynamoSamples": "3.3.0.6316",
       "Greg": "3.0.1.4707",
       "GregRevitAuth": "3.0.8935.26399",
       "pythonnet_py38_win": "2.5.1",

src/Libraries/RevitNodes/Elements/CurtainPanel.cs

@@ -381,7 +381,7 @@ public static CurtainPanel[] ByElement(Element hostingElement)
                     if (panel is Autodesk.Revit.DB.Panel)
                     {
                         ElementId hostPanelId = (panel as Panel).FindHostPanel();
-                        if (hostPanelId.IntegerValue != -1)
+                        if (hostPanelId.Value != -1)
                         {
                             result.Add(null);
                         }

src/Libraries/RevitNodes/Elements/Floor.cs

@@ -219,7 +219,7 @@ public Floor AddPoint(Pt point)
 
             TransactionManager.Instance.EnsureInTransaction(DocumentManager.Instance.CurrentDBDocument);
             this.InternalFloor.GetSlabShapeEditor().Enable();
-            this.InternalFloor.GetSlabShapeEditor().DrawPoint(point.ToXyz());
+            this.InternalFloor.GetSlabShapeEditor().AddPoint(point.ToXyz());
             TransactionManager.Instance.TransactionTaskDone();
 
             return this;

src/Libraries/RevitNodes/Elements/InternalUtilities/ElementUtils.cs

@@ -111,7 +111,7 @@ public static object GetParameterValue(Autodesk.Revit.DB.Parameter param)
         /// </summary>
         /// <param name="parameter"></param>
         /// <returns></returns>
-        /// <exception cref="ApplicationException"></exception>
+        /// <exception cref="System.ApplicationException"></exception>
         [SupressImportIntoVM]
         public static Type GetParameterType(Elements.Parameter parameter)
         {

src/Libraries/RevitNodes/Elements/InternalUtilities/ElementWrapper.cs

@@ -239,6 +239,8 @@ public static DraftingView Wrap(Autodesk.Revit.DB.ViewDrafting view, bool isRevi
             return DraftingView.FromExisting(view, isRevitOwned);
         }
 
+
+        [System.Obsolete("This method is deprecated with the introduction of the new Toposolid elements. It is recommended that Toposolid elements should be used in place of Topography elements.")]
         public static Topography Wrap(Autodesk.Revit.DB.Architecture.TopographySurface topoSurface, bool isRevitOwned)
         {
             return Topography.FromExisting(topoSurface, isRevitOwned);

src/Libraries/RevitNodes/Elements/Roof.cs

@@ -240,7 +240,7 @@ public void AddPoint(Pt point)
 
             TransactionManager.Instance.EnsureInTransaction(DocumentManager.Instance.CurrentDBDocument);
             this.InternalRoof.GetSlabShapeEditor().Enable();
-            this.InternalRoof.GetSlabShapeEditor().DrawPoint(point.ToXyz());
+            this.InternalRoof.GetSlabShapeEditor().AddPoint(point.ToXyz());
             TransactionManager.Instance.TransactionTaskDone();
         }
 

src/Libraries/RevitNodes/Elements/Topography.cs

@@ -12,6 +12,7 @@
 namespace Revit.Elements
 {
     [DynamoServices.RegisterForTrace]
+    [Obsolete("This method is deprecated with the introduction of the new Toposolid elements. It is recommended that Toposolid elements should be used in place of Topography elements.")]
     public class Topography : Element
     {
         #region internal properties
@@ -59,6 +60,7 @@ public Autodesk.DesignScript.Geometry.Mesh Mesh
 
         #region private constructors
 
+        [Obsolete("This method is deprecated with the introduction of the new Toposolid elements. It is recommended that Toposolid elements should be used in place of Topography elements.")]
         private Topography(IList<XYZ> points)
         {
             SafeInit(() => InitTopography(points));
@@ -78,6 +80,7 @@ private Topography(TopographySurface topoSurface)
         /// Initialize a Topography element
         /// </summary>
         /// <param name="points"></param>
+        [Obsolete("This method is deprecated with the introduction of the new Toposolid elements. It is recommended that Toposolid elements should be used in place of Topography elements.")]
         private void InitTopography(IList<XYZ> points)
         {
             //Phase 1 - Check to see if the object exists and should be rebound

src/Libraries/RevitNodes/Elements/Views/Packing/OutOfSpaceException.cs

@@ -47,18 +47,18 @@ public OutOfSpaceException(string message) : base(message) { }
         /// <param name="inner">Preceding exception that has caused this exception</param>
         public OutOfSpaceException(string message, Exception inner) : base(message, inner) { }
 
-#if !NO_SERIALIZATION
+//#if !NO_SERIALIZATION
 
-        /// <summary>Initializes the exception from its serialized state</summary>
-        /// <param name="info">Contains the serialized fields of the exception</param>
-        /// <param name="context">Additional environmental informations</param>
-        protected OutOfSpaceException(
-          System.Runtime.Serialization.SerializationInfo info,
-          System.Runtime.Serialization.StreamingContext context
-        ) :
-            base(info, context) { }
+//        /// <summary>Initializes the exception from its serialized state</summary>
+//        /// <param name="info">Contains the serialized fields of the exception</param>
+//        /// <param name="context">Additional environmental informations</param>
+//        protected OutOfSpaceException(
+//          System.Runtime.Serialization.SerializationInfo info,
+//          System.Runtime.Serialization.StreamingContext context
+//        ) :
+//            base(info, context) { }
 
-#endif
+//#endif
 
     }
 

src/Libraries/RevitNodes/Filter/FilterRule.cs

@@ -91,7 +91,7 @@ public static FilterRule ByRuleType(string type, object value, Elements.Paramete
                 Type parameterType = Revit.Elements.InternalUtilities.ElementUtils.GetParameterType(parameter);
                 convertedValue = Convert.ChangeType(value, parameterType);
             }
-            catch (Exception ex)
+            catch (Exception)
             {
                 throw new ApplicationException(Properties.Resources.InputValueParameterValueTypeMismatch);
             }        

src/Libraries/RevitNodes/GeometryConversion/DynamoToRevitBRep.cs

@@ -70,7 +70,7 @@ private static GeometryObject ToRevitType(Autodesk.DesignScript.Geometry.Topolog
             {
                 using (var geom = protoFace.SurfaceGeometry())
                 {
-                    using (var ngeom = geom.ToNurbsSurface())
+                    using (var ngeom = geom.ToNurbsSurface(true))
                     {
                         bool flipped = false;
                         // Check if the nurbs surface has flipped compared to the original surface

src/Libraries/RevitNodes/GeometryConversion/RevitToProtoFace.cs

@@ -43,7 +43,7 @@ public static IEnumerable<Surface> ToProtoType(this Autodesk.Revit.DB.Face revit
                 Surface converted;
                 try
                 {
-                    converted = untrimmedSrf.TrimWithEdgeLoops(curveLoops);
+                    converted = untrimmedSrf.TrimWithEdgeLoops(curveLoops, 0.001);
                 }
                 catch (Exception e)
                 {

src/Libraries/RevitNodesUI/RevitDropDown.cs

@@ -371,6 +371,7 @@ private Element GetInputElement()
             return null == elem ? null : elem.InternalElement;
         }
 
+        [Obsolete]
         protected override void SerializeCore(XmlElement nodeElement, SaveContext context)
         {
             base.SerializeCore(nodeElement, context);
@@ -387,6 +388,7 @@ protected override void SerializeCore(XmlElement nodeElement, SaveContext contex
 
         }
 
+        [Obsolete]
         protected override void DeserializeCore(XmlElement nodeElement, SaveContext context)
         {
             base.DeserializeCore(nodeElement, context);

test/Libraries/RevitNodesTests/Elements/TopographyTests.cs

@@ -10,6 +10,7 @@
 namespace RevitNodesTests.Elements
 {
     [TestFixture]
+#pragma warning disable CS0618 // Type or member is obsolete
     class TopographyTests : RevitNodeTestBase
     {
         [Test]
@@ -73,4 +74,5 @@ public void ByPoints_Mutation()
             topoSurf.Points[4].ShouldBeApproximately(p6);
         }
     }
+#pragma warning restore CS0618
 }

test/Libraries/RevitNodesTests/GeometryConversion/RevitToProtoMeshTests.cs

@@ -18,6 +18,7 @@ public class RevitToProtoMeshTests : RevitNodeTestBase
     {
         [Test]
         [TestModel(@".\topography.rvt")]
+#pragma warning disable CS0618 // Type or member is obsolete
         public void ToProtoType_ShouldReturnCorrectlyScaledMesh()
         {
             var allMeshesInDoc =
@@ -47,5 +48,6 @@ public void ToProtoType_ShouldReturnCorrectlyScaledMesh()
 
             convertedMesh.Dispose();
         }
+#pragma warning restore CS0618
     }
 }