Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segments): delete functionality for segments #1651

Merged
merged 8 commits into from
Jan 3, 2025
Merged

Conversation

jskelin
Copy link
Contributor

@jskelin jskelin commented Dec 13, 2024

With these changes, delete functionality for segments is supported. To declare segment config for delete, in delete.yaml file add an entry like this for indirect reference:

- type: segment
  project: my-project
  id: monaco-config-id

or for direct reference like next:

- type: segment
  objectId: origin-object-ID

@jskelin jskelin requested a review from a team as a code owner December 13, 2024 14:25
@jskelin jskelin self-assigned this Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

Unit Test Results

1 961 tests  +20   1 960 ✅ +20   54s ⏱️ ±0s
  135 suites + 1       1 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit cec26f4. ± Comparison against base commit e778051.

This pull request removes 3 and adds 23 tests. Note that renamed tests count towards both.
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Documents/config_declared_via_coordinate_have_multiple_match_-_delete_them_all
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/writer ‑ TestWriteConfigs/Segment_should_fail_if_FF_MONACO_FEAT_SEGMENTSis_not_set
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/writer ‑ TestWriteConfigs/segment
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDeleteAll_Segments
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDeleteAll_Segments/FF_is_turned_off
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDeleteAll_Segments/simple_case
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Documents/config_declared_via_coordinate_have_multiple_match_-_no_delete,_no_error
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Segments
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Segments/simple_case
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Segments/simple_case_with_FF_turned_off
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete/internal/segment ‑ TestDeleteAll
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete/internal/segment ‑ TestDeleteAll/deletion_continues_even_if_error_occurs_during_delete
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete/internal/segment ‑ TestDeleteAll/simple_case
…

♻️ This comment has been updated with latest results.

@jskelin jskelin added the release-notes This feature/fix should be mentioned in release notes label Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

E2E Test Results

    4 files   -   1    272 suites   - 132   27m 39s ⏱️ - 45m 55s
2 080 tests + 18  2 078 ✅ + 18  2 💤 ±0  0 ❌ ±0 
2 232 runs   - 106  2 230 ✅  - 106  2 💤 ±0  0 ❌ ±0 

Results for commit cec26f4. ± Comparison against base commit e778051.

This pull request removes 5 and adds 23 tests. Note that renamed tests count towards both.
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationClassic
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationPlatform
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Documents/config_declared_via_coordinate_have_multiple_match_-_delete_them_all
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/writer ‑ TestWriteConfigs/Segment_should_fail_if_FF_MONACO_FEAT_SEGMENTSis_not_set
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/writer ‑ TestWriteConfigs/segment
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDeleteAll_Segments
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDeleteAll_Segments/FF_is_turned_off
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDeleteAll_Segments/simple_case
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Documents/config_declared_via_coordinate_have_multiple_match_-_no_delete,_no_error
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Segments
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Segments/simple_case
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete ‑ TestDelete_Segments/simple_case_with_FF_turned_off
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete/internal/segment ‑ TestDeleteAll
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete/internal/segment ‑ TestDeleteAll/deletion_continues_even_if_error_occurs_during_delete
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/delete/internal/segment ‑ TestDeleteAll/simple_case
…

♻️ This comment has been updated with latest results.

@jskelin jskelin changed the title Delete functionality for segments feat(segments): delete functionality for segments Dec 16, 2024
@jskelin jskelin force-pushed the feat/GFF/delete branch 3 times, most recently from 7fda2be to 5fc72b5 Compare December 20, 2024 12:22
@jskelin jskelin added the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Dec 20, 2024
Copy link

sonarqubecloud bot commented Jan 3, 2025

@arthurpitman arthurpitman added run-e2e-test Manually trigger the E2E tests for reviewed PRs and removed run-e2e-test Manually trigger the E2E tests for reviewed PRs labels Jan 3, 2025
@jskelin jskelin merged commit 2f143b5 into main Jan 3, 2025
22 checks passed
@jskelin jskelin deleted the feat/GFF/delete branch January 3, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes This feature/fix should be mentioned in release notes run-e2e-test Manually trigger the E2E tests for reviewed PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants