Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove documents feature flags #1664

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

arthurpitman
Copy link
Contributor

This PR removes MONACO_FEAT_DOCUMENTS and MONACO_FEAT_DELETE_DOCUMENTS feature flags as the features are now stable.

@arthurpitman arthurpitman requested a review from a team as a code owner January 7, 2025 15:03
@arthurpitman arthurpitman added the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Unit Test Results

1 964 tests   - 1   1 963 ✅  - 1   54s ⏱️ ±0s
  135 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 3b05413. ± Comparison against base commit 9ab8145.

This pull request removes 1 test.
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/loader ‑ Test_parseConfigs/Document_config_with_FF_off

♻️ This comment has been updated with latest results.

@arthurpitman arthurpitman force-pushed the refactor/remove-documents-ffs branch from 911119d to 0e9e3b3 Compare January 7, 2025 15:07
@arthurpitman arthurpitman force-pushed the refactor/remove-documents-ffs branch from 0e9e3b3 to 3b05413 Compare January 7, 2025 15:08
@arthurpitman arthurpitman removed the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Jan 7, 2025
Copy link

sonarqubecloud bot commented Jan 7, 2025

@arthurpitman arthurpitman added the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

E2E Test Results

    4 files  ±0    272 suites  ±0   24m 42s ⏱️ + 1m 50s
2 083 tests  - 1  2 081 ✅  - 1  2 💤 ±0  0 ❌ ±0 
2 235 runs   - 1  2 233 ✅  - 1  2 💤 ±0  0 ❌ ±0 

Results for commit 3b05413. ± Comparison against base commit 9ab8145.

This pull request removes 1 test.
github.com/dynatrace/dynatrace-configuration-as-code/v2/pkg/persistence/config/loader ‑ Test_parseConfigs/Document_config_with_FF_off

@arthurpitman arthurpitman merged commit 934c05b into main Jan 7, 2025
22 checks passed
@arthurpitman arthurpitman deleted the refactor/remove-documents-ffs branch January 7, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e-test Manually trigger the E2E tests for reviewed PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants